Add strict mode directive (#1003)

Fdawgs · web-flow · commit ff0e327c548e · 2025-03-31T22:31:02.000-07:00
diff --git a/.eslintrc b/.eslintrc
@@ -7,7 +7,12 @@
     "mocha": true,
     "worker": true
   },
+  "parserOptions": {
+    // airbnb-base sets this to "modules" for ESM but CJS is being used
+    "sourceType": "script"
+  },
   "rules": {
+    "strict": ["error", "global"],
     "no-underscore-dangle": 0,
     "no-console": 0,
     "global-require": 0,
diff --git a/benchmarks/node/memory-benchmark.js b/benchmarks/node/memory-benchmark.js
@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 // Note: getting replicable results from this script requires:
 // (1) Running with the `--expose-gc` flag,
 // (2) adding `global.gc()` within the `index.js` file
diff --git a/benchmarks/node/speed-benchmark.js b/benchmarks/node/speed-benchmark.js
@@ -1,4 +1,7 @@
 #!/usr/bin/env node
+
+'use strict';
+
 const path = require('path');
 const { createWorker } = require('../..');
 
diff --git a/examples/node/download-pdf.js b/examples/node/download-pdf.js
@@ -1,4 +1,7 @@
 #!/usr/bin/env node
+
+'use strict';
+
 const path = require('path');
 const fs = require('fs');
 const { createWorker } = require('../..');
diff --git a/examples/node/image-processing.js b/examples/node/image-processing.js
@@ -1,4 +1,7 @@
 #!/usr/bin/env node
+
+'use strict';
+
 const path = require('path');
 const fs = require('fs');
 const { createWorker } = require('../..');
diff --git a/examples/node/recognize.js b/examples/node/recognize.js
@@ -1,4 +1,7 @@
 #!/usr/bin/env node
+
+'use strict';
+
 const path = require('path');
 const { createWorker } = require('../..');
 
diff --git a/examples/node/scheduler.js b/examples/node/scheduler.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const { createWorker, createScheduler } = require('../..');
 
diff --git a/scripts/server.js b/scripts/server.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const webpack = require('webpack');
 const middleware = require('webpack-dev-middleware');
 const express = require('express');
diff --git a/scripts/test-helper.js b/scripts/test-helper.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const constants = require('../tests/constants');
 global.expect = require('expect.js');
 global.fs = require('fs');
diff --git a/scripts/webpack.config.common.js b/scripts/webpack.config.common.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   resolve: {
     fallback: {
diff --git a/scripts/webpack.config.prod.js b/scripts/webpack.config.prod.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const common = require('./webpack.config.common');
 const webpack = require('webpack');
diff --git a/src/Tesseract.js b/src/Tesseract.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const createWorker = require('./createWorker');
 
 const recognize = async (image, langs, options) => {
diff --git a/src/constants/OEM.js b/src/constants/OEM.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /*
  * OEM = OCR Engine Mode, and there are 4 possible modes.
  *
diff --git a/src/constants/PSM.js b/src/constants/PSM.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /*
  * PSM = Page Segmentation Mode
  */
diff --git a/src/constants/defaultOptions.js b/src/constants/defaultOptions.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   /*
    * Use BlobURL for worker script by default
diff --git a/src/constants/imageType.js b/src/constants/imageType.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   COLOR: 0,
   GREY: 1,
diff --git a/src/constants/languages.js b/src/constants/languages.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /*
  * languages with existing tesseract traineddata
  * https://tesseract-ocr.github.io/tessdoc/Data-Files#data-files-for-version-400-november-29-2016
diff --git a/src/createJob.js b/src/createJob.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const getId = require('./utils/getId');
 
 let jobCounter = 0;
diff --git a/src/createScheduler.js b/src/createScheduler.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const createJob = require('./createJob');
 const { log } = require('./utils/log');
 const getId = require('./utils/getId');
diff --git a/src/createWorker.js b/src/createWorker.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const resolvePaths = require('./utils/resolvePaths');
 const createJob = require('./createJob');
 const { log } = require('./utils/log');
diff --git a/src/index.js b/src/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Entry point for tesseract.js, should be the entry when bundling.
diff --git a/src/utils/getEnvironment.js b/src/utils/getEnvironment.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (key) => {
   const env = {};
 
diff --git a/src/utils/getId.js b/src/utils/getId.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (prefix, cnt) => (
   `${prefix}-${cnt}-${Math.random().toString(16).slice(3, 8)}`
 );
diff --git a/src/utils/log.js b/src/utils/log.js
@@ -1,3 +1,5 @@
+'use strict';
+
 let logging = false;
 
 exports.logging = logging;
diff --git a/src/utils/resolvePaths.js b/src/utils/resolvePaths.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const isBrowser = require('./getEnvironment')('type') === 'browser';
 
 const resolveURL = isBrowser ? s => (new URL(s, window.location.href)).href : s => s; // eslint-disable-line
diff --git a/src/worker-script/browser/cache.js b/src/worker-script/browser/cache.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { set, get, del } = require('idb-keyval');
 
 module.exports = {
diff --git a/src/worker-script/browser/getCore.js b/src/worker-script/browser/getCore.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { simd } = require('wasm-feature-detect');
 const coreVersion = require('../../../package.json').dependencies['tesseract.js-core'];
 
diff --git a/src/worker-script/browser/gunzip.js b/src/worker-script/browser/gunzip.js
@@ -1 +1,3 @@
+'use strict';
+
 module.exports = require('zlibjs').gunzipSync;
diff --git a/src/worker-script/browser/index.js b/src/worker-script/browser/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Browser worker scripts
diff --git a/src/worker-script/constants/defaultOutput.js b/src/worker-script/constants/defaultOutput.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /*
  * default output formats for tesseract.js
  */
diff --git a/src/worker-script/index.js b/src/worker-script/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Worker script for browser and node
diff --git a/src/worker-script/node/cache.js b/src/worker-script/node/cache.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const util = require('util');
 const fs = require('fs');
 
diff --git a/src/worker-script/node/getCore.js b/src/worker-script/node/getCore.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { simd } = require('wasm-feature-detect');
 const OEM = require('../../constants/OEM');
 
diff --git a/src/worker-script/node/gunzip.js b/src/worker-script/node/gunzip.js
@@ -1 +1,3 @@
+'use strict';
+
 module.exports = require('zlib').gunzipSync;
diff --git a/src/worker-script/node/index.js b/src/worker-script/node/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Tesseract Worker Script for Node
diff --git a/src/worker-script/utils/arrayBufferToBase64.js b/src/worker-script/utils/arrayBufferToBase64.js
@@ -1,3 +1,5 @@
+'use strict';
+
 // Copied from https://gist.github.com/jonleighton/958841
 // Copyright 2011 Jon Leighton, MIT LICENSE
 
diff --git a/src/worker-script/utils/dump.js b/src/worker-script/utils/dump.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Dump data to a big JSON tree
diff --git a/src/worker-script/utils/setImage.js b/src/worker-script/utils/setImage.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const bmp = require('bmp-js');
 
 /**
diff --git a/src/worker/browser/defaultOptions.js b/src/worker/browser/defaultOptions.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const version = require('../../../package.json').version;
 const defaultOptions = require('../../constants/defaultOptions');
 
diff --git a/src/worker/browser/index.js b/src/worker/browser/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Tesseract Worker adapter for browser
diff --git a/src/worker/browser/loadImage.js b/src/worker/browser/loadImage.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * readFromBlobOrFile
  *
diff --git a/src/worker/browser/onMessage.js b/src/worker/browser/onMessage.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (worker, handler) => {
   worker.onmessage = ({ data }) => { // eslint-disable-line
     handler(data);
diff --git a/src/worker/browser/send.js b/src/worker/browser/send.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * send
  *
diff --git a/src/worker/browser/spawnWorker.js b/src/worker/browser/spawnWorker.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * spawnWorker
  *
diff --git a/src/worker/browser/terminateWorker.js b/src/worker/browser/terminateWorker.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * terminateWorker
  *
diff --git a/src/worker/node/defaultOptions.js b/src/worker/node/defaultOptions.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const defaultOptions = require('../../constants/defaultOptions');
 
diff --git a/src/worker/node/index.js b/src/worker/node/index.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  *
  * Tesseract Worker impl. for node (using child_process)
diff --git a/src/worker/node/loadImage.js b/src/worker/node/loadImage.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const util = require('util');
 const fs = require('fs');
 const fetch = require('node-fetch');
diff --git a/src/worker/node/onMessage.js b/src/worker/node/onMessage.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (worker, handler) => {
   worker.on('message', handler);
 };
diff --git a/src/worker/node/send.js b/src/worker/node/send.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * send
  *
diff --git a/src/worker/node/spawnWorker.js b/src/worker/node/spawnWorker.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { Worker } = require('worker_threads');
 
 /**
diff --git a/src/worker/node/terminateWorker.js b/src/worker/node/terminateWorker.js
@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * terminateWorker
  *
diff --git a/tests/FS.test.js b/tests/FS.test.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { createWorker } = Tesseract;
 const FS_WAIT = 500;
 let worker;
diff --git a/tests/constants.js b/tests/constants.js
diff --git a/tests/detect.test.js b/tests/detect.test.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { createWorker } = Tesseract;
 let worker;
 before(async function cb() {
diff --git a/tests/recognize.test.js b/tests/recognize.test.js
@@ -1,5 +1,8 @@
+'use strict';
+
 const { createWorker, PSM } = Tesseract;
 let worker;
+let workerLegacy;
 before(async function cb() {
   this.timeout(0);
   worker = await createWorker('eng', 1, OPTIONS);
diff --git a/tests/scheduler.test.js b/tests/scheduler.test.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const { createScheduler, createWorker } = Tesseract;
 
 let workers = [];

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const path = require('path');`
`2`	`4`	`const { createWorker, createScheduler } = require('../..');`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const webpack = require('webpack');`
`2`	`4`	`const middleware = require('webpack-dev-middleware');`
`3`	`5`	`const express = require('express');`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const constants = require('../tests/constants');`
`2`	`4`	`global.expect = require('expect.js');`
`3`	`5`	`global.fs = require('fs');`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`module.exports = {`
`2`	`4`	`resolve: {`
`3`	`5`	`fallback: {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const createWorker = require('./createWorker');`
`2`	`4`
`3`	`5`	`const recognize = async (image, langs, options) => {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`/*`
`2`	`4`	`* OEM = OCR Engine Mode, and there are 4 possible modes.`
`3`	`5`	`*`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const getId = require('./utils/getId');`
`2`	`4`
`3`	`5`	`let jobCounter = 0;`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const createJob = require('./createJob');`
`2`	`4`	`const { log } = require('./utils/log');`
`3`	`5`	`const getId = require('./utils/getId');`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`const resolvePaths = require('./utils/resolvePaths');`
`2`	`4`	`const createJob = require('./createJob');`
`3`	`5`	`const { log } = require('./utils/log');`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`/**`
`2`	`4`	`*`
`3`	`5`	`* Entry point for tesseract.js, should be the entry when bundling.`