Merge pull request #19950 from timvandermeij/intermittent-all-await

timvandermeij · web-flow · commit 60574fb7e307 · 2025-05-18T19:12:48.000+02:00
Fix missing `await` for asynchronous method calls in the integration tests
diff --git a/test/integration/freetext_editor_spec.mjs b/test/integration/freetext_editor_spec.mjs
@@ -669,7 +669,7 @@ describe("FreeText Editor", () => {
             }
           );
 
-          page.evaluate(() => {
+          await page.evaluate(() => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {
@@ -1290,7 +1290,7 @@ describe("FreeText Editor", () => {
             ".selectedEditor .internal"
           );
 
-          page.evaluate(() => {
+          await page.evaluate(() => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {
diff --git a/test/integration/highlight_editor_spec.mjs b/test/integration/highlight_editor_spec.mjs
@@ -626,7 +626,7 @@ describe("Highlight Editor", () => {
           const { width: prevWidth } = await getRect(page, editorSelector);
 
           value = 24;
-          page.evaluate(val => {
+          await page.evaluate(val => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {
@@ -763,7 +763,7 @@ describe("Highlight Editor", () => {
 
           const { width: prevWidth } = await getRect(page, editorSelector);
 
-          page.evaluate(val => {
+          await page.evaluate(val => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {
diff --git a/test/integration/ink_editor_spec.mjs b/test/integration/ink_editor_spec.mjs
@@ -302,7 +302,7 @@ describe("Ink Editor", () => {
           await page.mouse.up();
           await awaitPromise(clickHandle);
 
-          page.mouse.click(rect.x - 10, rect.y + 10);
+          await page.mouse.click(rect.x - 10, rect.y + 10);
           await page.waitForSelector(`${getEditorSelector(0)}.disabled`);
         })
       );
@@ -583,7 +583,7 @@ describe("Ink Editor", () => {
           }
 
           const red = "#ff0000";
-          page.evaluate(value => {
+          await page.evaluate(value => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {
@@ -763,7 +763,7 @@ describe("Ink Editor", () => {
           await selectEditor(page, pdfjsA);
 
           const red = "#ff0000";
-          page.evaluate(value => {
+          await page.evaluate(value => {
             window.PDFViewerApplication.eventBus.dispatch(
               "switchannotationeditorparams",
               {

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,7 @@ describe("FreeText Editor", () => {`
`669`	`669`	`}`
`670`	`670`	`);`
`671`	`671`
`672`		`- page.evaluate(() => {`
	`672`	`+ await page.evaluate(() => {`
`673`	`673`	`window.PDFViewerApplication.eventBus.dispatch(`
`674`	`674`	`"switchannotationeditorparams",`
`675`	`675`	`{`
`@@ -1290,7 +1290,7 @@ describe("FreeText Editor", () => {`
`1290`	`1290`	`".selectedEditor .internal"`
`1291`	`1291`	`);`
`1292`	`1292`
`1293`		`- page.evaluate(() => {`
	`1293`	`+ await page.evaluate(() => {`
`1294`	`1294`	`window.PDFViewerApplication.eventBus.dispatch(`
`1295`	`1295`	`"switchannotationeditorparams",`
`1296`	`1296`	`{`
Original file line number	Diff line number	Diff line change
`@@ -626,7 +626,7 @@ describe("Highlight Editor", () => {`
`626`	`626`	`const { width: prevWidth } = await getRect(page, editorSelector);`
`627`	`627`
`628`	`628`	`value = 24;`
`629`		`- page.evaluate(val => {`
	`629`	`+ await page.evaluate(val => {`
`630`	`630`	`window.PDFViewerApplication.eventBus.dispatch(`
`631`	`631`	`"switchannotationeditorparams",`
`632`	`632`	`{`
`@@ -763,7 +763,7 @@ describe("Highlight Editor", () => {`
`763`	`763`
`764`	`764`	`const { width: prevWidth } = await getRect(page, editorSelector);`
`765`	`765`
`766`		`- page.evaluate(val => {`
	`766`	`+ await page.evaluate(val => {`
`767`	`767`	`window.PDFViewerApplication.eventBus.dispatch(`
`768`	`768`	`"switchannotationeditorparams",`
`769`	`769`	`{`