Skip to content

Ignore empty paths when optimizing constructPath operations (issue 19971) #19972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Ignore empty paths when optimizing constructPath operations (issue 19971) #19972

merged 1 commit into from
May 23, 2025
+23 −12

Conversation

Snuffleupagus
Copy link
Collaborator

Note how we're handling empty paths in src/display/canvas.js, hence we need add similar code in the QueueOptimizer as well.

@Snuffleupagus
Ignore empty paths when optimizing constructPath operations (issue …
c5449a9 
…19971)

Note how we're handling empty paths in [src/display/canvas.js](https://github.com/mozilla/pdf.js/blob/a8e05d82e23056ddc2c28f83854b6f74ffa4bebc/src/display/canvas.js#L1423-L1428), hence we need add similar code in the `QueueOptimizer` as well.
@Snuffleupagus Snuffleupagus linked an issue May 23, 2025 that may be closed by this pull request
[Bug]: PDF causes TypeError and doesn't fully render. #19971
Closed
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/be8d35352b8be28/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/79f20a6fb6d26b9/output.txt

@Snuffleupagus Snuffleupagus added the release-blocker Blocker for the upcoming release label May 23, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/be8d35352b8be28/output.txt

Total script time: 29.75 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus Snuffleupagus requested a review from calixteman May 23, 2025 12:36
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/79f20a6fb6d26b9/output.txt

Total script time: 55.55 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

calixteman
calixteman approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit f11d8b0 into mozilla:master May 23, 2025
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f01e8a3b2dc1e7e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/4fea67bd2d0648e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4fea67bd2d0648e/output.txt

Total script time: 15.96 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f01e8a3b2dc1e7e/output.txt

Total script time: 25.20 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-19971 branch May 23, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core regression release-blocker Blocker for the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: PDF causes TypeError and doesn't fully render.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman