Skip to content

[Editor] Change mode when double clicking on an editor #19969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Editor] Change mode when double clicking on an editor #19969

merged 1 commit into from
May 28, 2025
+152 −48

Conversation

calixteman
Copy link
Contributor

It was only possible to double click on a FreeText editor while being in ink mode (or any other).

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/05200b8fd1b97da/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f9cddab41eea07e/output.txt

@calixteman calixteman force-pushed the editor_inconsistencies branch from e3ae2ab to a007f2d Compare May 22, 2025 19:14
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/05200b8fd1b97da/output.txt

Total script time: 22.80 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f9cddab41eea07e/output.txt

Total script time: 39.13 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the editor_inconsistencies branch from a007f2d to 9719b17 Compare May 23, 2025 16:28
@calixteman calixteman dismissed a stale review May 23, 2025 16:30

Insignificant.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/229c99015ea17e8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4487fa5d8a5881b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/229c99015ea17e8/output.txt

Total script time: 12.95 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4487fa5d8a5881b/output.txt

Total script time: 29.61 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the editor_inconsistencies branch 2 times, most recently from 12fcfe7 to c8c03e1 Compare May 23, 2025 17:54
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/44504b03523837b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/03497ffdfb6872a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/03497ffdfb6872a/output.txt

Total script time: 12.98 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/44504b03523837b/output.txt

Total script time: 29.49 mins

  • Integration Tests: FAILED

@calixteman calixteman requested a review from Snuffleupagus May 23, 2025 18:55
Snuffleupagus
Snuffleupagus approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman
[Editor] Change mode when double clicking on an editor
47e69e9 
It was only possible to double click on a FreeText editor while being in ink mode (or any other).
@calixteman calixteman force-pushed the editor_inconsistencies branch from c8c03e1 to 47e69e9 Compare May 28, 2025 15:49
@calixteman calixteman merged commit d63aabd into mozilla:master May 28, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus