Support Type3 fonts with an incomplete /FontDescriptor dictionary (issue 19954) #19955
Conversation
…sue 19954) We have a fallback for the common case of Type3 fonts without a /FontDescriptor dictionary, however we also need to handle the case where it's present but lacking the required /FontName entry.
|
Ok well this matches exactly what I was thinking about :) I was however also removing the |
We might actually be able to simplify things even more here, unless I'm overlooking something obvious. |
|
/botio unittest |
Snuffleupagus
force-pushed
the
issue-19954
branch
from
6051625 to
331e32e
Compare
Snuffleupagus
force-pushed
the
issue-19954
branch
from
331e32e to
bb98f1e
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8dc3fe3ba8f98e4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/79f862156c6d4a7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8dc3fe3ba8f98e4/output.txt Total script time: 30.13 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/79f862156c6d4a7/output.txt Total script time: 56.84 mins
|
Part of this is very old code, which we can now simplify a little bit.
Snuffleupagus
force-pushed
the
issue-19954
branch
from
bb98f1e to
c02ea0c
Compare
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/727ef8e95a44a47/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/376221333231559/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/727ef8e95a44a47/output.txt Total script time: 25.58 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/376221333231559/output.txt Total script time: 16.12 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2001c6742065a4c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f3815addc4cd14f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f3815addc4cd14f/output.txt Total script time: 16.04 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2001c6742065a4c/output.txt Total script time: 25.19 mins
|
We have a fallback for the common case of Type3 fonts without a /FontDescriptor dictionary, however we also need to handle the case where it's present but lacking the required /FontName entry.