Fix intermittent failure in the "supports specifying a custom origin" viewer integration test #19952
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3c8ede823a1c2b9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/88a7235c7eb8fb2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3c8ede823a1c2b9/output.txt Total script time: 12.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/88a7235c7eb8fb2/output.txt Total script time: 29.63 mins
|
timvandermeij
force-pushed
the
intermittent-viewer-origin
branch
2 times, most recently
from
cf658f0 to
d818a5e
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/13073f974737630/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1b66907c06be890/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1b66907c06be890/output.txt Total script time: 12.95 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/13073f974737630/output.txt Total script time: 30.97 mins
|
… viewer integration test The problem in the original code is that `getTextAt` is called too early and therefore returns unexpected text content. This can happen because we call `increaseScale` and then wait for the page's text layer to be visible, but it can take some time before the zoom actually occurs/completes in the viewer and in the meantime the old (pre-zoom) text layer may still be visible, causing us to continue too soon because we don't validate that we're dealing with the post-zoom text layer. This commit fixes the issue by simply waiting for the expected text to show up at the given origin coordinates, which makes the test work independent of viewer actions/timing.
timvandermeij
force-pushed
the
intermittent-viewer-origin
branch
from
d818a5e to
f251e60
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/eb55e466e5a17a0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6eb9d4a1cff2724/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/eb55e466e5a17a0/output.txt Total script time: 13.00 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6eb9d4a1cff2724/output.txt Total script time: 31.07 mins
|
The problem in the original code is that
getTextAtis called too early and therefore returns unexpected text content. This can happen because we callincreaseScaleand then wait for the page's text layer to be visible, but it can take some time before the zoom actually occurs/completes in the viewer and in the meantime the old (pre-zoom) text layer may still be visible, causing us to continue too soon because we don't validate that we're dealing with the post-zoom text layer.This commit fixes the issue by simply waiting for the expected text to show up at the given origin coordinates, which makes the test work independent of viewer actions/timing.
Fixes #19951.