Replace PDFWorker.fromPort with a generic PDFWorker.create method
#19943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to simply invoke `PDFWorker.create` unconditionally from the `getDocument` function, without having to manually check if a global `workerPort` is available first.
Snuffleupagus
force-pushed
the
PDFWorker-create
branch
from
0fe2a15 to
7a9a10a
Compare
This replaces, wherever possible, the old semi-private fields and methods with actually private ones.
Snuffleupagus
force-pushed
the
PDFWorker-create
branch
from
7a9a10a to
fc697b3
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c2bf127b91802bc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c2bf127b91802bc/output.txt Total script time: 1.05 mins Published |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c6999da9f1f374a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c6999da9f1f374a/output.txt Total script time: 30.49 mins
|
timvandermeij
approved these changes
May 17, 2025
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
PDFWorker.fromPortwith a genericPDFWorker.createmethodThis allows us to simply invoke
PDFWorker.createunconditionally from thegetDocumentfunction, without having to manually check if a globalworkerPortis available first.Utilize private fields and methods more in the
PDFWorkerclassThis replaces, wherever possible, the old semi-private fields and methods with actually private ones.