Ensure that the viewer clears the workerPort option when using "fake" workers
#19939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/36beb94b5d72daf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/36beb94b5d72daf/output.txt Total script time: 0.96 mins Published |
Snuffleupagus
changed the title
workerPort option when using "fake" workersworkerPort option when using "fake" workers
…e" workers Without this "fake" workers may be ignored in the API, which isn't really what you want when manually providing the `disableWorker=true` hash parameter. (Note that this requires the `pdfBugEnabled` option/preference to be set as well.) Also, after the changes in PR 19810 we can just load the "fake" worker directly in development mode and don't need to manually assign it to the global scope.
Snuffleupagus
force-pushed
the
disableWorker-clear-workerPort
branch
from
bd2355f to
eef1e3e
Compare
|
I'm just using this to check that the win bot is ok: |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/751d06f5b7c6a9b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/751d06f5b7c6a9b/output.txt Total script time: 10.55 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this "fake" workers may be ignored in the API, which isn't really what you want when manually providing the
disableWorker=truehash parameter. (Note that this requires thepdfBugEnabledoption/preference to be set as well.)Also, after the changes in PR #19810 we can just load the "fake" worker directly in development mode and don't need to manually assign it to the global scope.