-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove unused OpenJPEG wasm fallback logic #19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh well, the unused code removal is working properly, so the tests for the transform need to be updated to actually use those functions :) |
b5f32ac
to
c2ba80a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the typo in the commit message: OpenJPG
-> OpenJPEG
.
c2ba80a
to
c979a8c
Compare
Emscripten generates code that allows the caller to provide the Wasm module (thorugh Module.instantiateWasm), with a fallback in case .instantiateWasm is not provided. We always define instantiateWasm, so we can hard-code the check and let our dead code elimination logic remove the unused fallback. This commit also improved the dead code elimination logic so that if a function declaration becomes unused as a result of removing dead code, the function itself is removed.
c979a8c
to
aebe0cb
Compare
Rebased to include the changes that removed I couldn't find a nice way to test for this, instead I made the webpack build fail (after emitting the files) if the generated bundle contains |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8630af930651a96/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f66c94119c82701/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f66c94119c82701/output.txt Total script time: 30.56 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8630af930651a96/output.txt Total script time: 61.79 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Closes #19921.
The diff for
pdf.worker.mjs
in the generic build is now: