Reduce duplication when computing the maximum canvas pixels #19915
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/afe35f3ccdd4205/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d0175b7178440b7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/afe35f3ccdd4205/output.txt Total script time: 12.48 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d0175b7178440b7/output.txt Total script time: 33.23 mins
|
*This is something that occurred to me when reviewing the latest PDF.js update in mozilla-central.* Currently we duplicate essentially the same code in both the `OutputScale.prototype.limitCanvas` and `PDFPageDetailView.prototype.update` methods, which seems unnecessary, and to avoid that we introduce a new `OutputScale.capPixels` method that is used to compute the maximum canvas pixels.
Snuffleupagus
force-pushed
the
OutputScale-capPixels
branch
from
6e4595a to
d5c534f
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/15117d056cbb603/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bb3ef610559ca1f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/15117d056cbb603/output.txt Total script time: 13.19 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bb3ef610559ca1f/output.txt Total script time: 35.82 mins
|
This is something that occurred to me when reviewing the latest PDF.js update in mozilla-central.
Currently we duplicate essentially the same code in both the
OutputScale.prototype.limitCanvasandPDFPageDetailView.prototype.updatemethods, which seems unnecessary, and to avoid that we introduce a newOutputScale.capPixelsmethod that is used to compute the maximum canvas pixels.