Skip to content

Fix arguments in toStyle call in CheckButton #19883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

gpanakkal
Copy link
Contributor

Just one fix - passes this as the first argument to toStyle in CheckButton.prototype.[$toHTML].

@Snuffleupagus
Copy link
Collaborator

@calixteman
Copy link
Contributor

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3fcd42c4ba49682/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b364a8fd8ae6d36/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/b364a8fd8ae6d36/output.txt

Total script time: 17.33 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3fcd42c4ba49682/output.txt

Total script time: 40.41 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman
Copy link
Contributor

@gpanakkal could you squash your commits (#19883 (comment)) ? thank you.

@gpanakkal gpanakkal force-pushed the checkbutton-tostyle branch from dce9188 to 7bba3bd Compare May 1, 2025 17:21
@gpanakkal
Copy link
Contributor Author

@gpanakkal could you squash your commits (#19883 (comment)) ? thank you.

Done!

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit 91bfe12 into mozilla:master May 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants