Remove debug code from the integration tests, and skip the "must check that canvas perfectly fits the page whatever the zoom level" integration test in Chrome #19812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so simplifies the code a bit, and such code is generally not checked in because it can easily be added locally if needed.
timvandermeij
force-pushed
the
disable-permafail
branch
from
aa6f06e to
607a277
Compare
timvandermeij
changed the title
… zoom level" integration test in Chrome This is a temporary measure to reduce noise until mozilla#19811 is fixed. Note that this shouldn't be an issue in terms of coverage because we still run the test in Firefox.
timvandermeij
force-pushed
the
disable-permafail
branch
from
607a277 to
923753a
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0903ac279936200/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5d9bfcf226d2749/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0903ac279936200/output.txt Total script time: 12.92 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5d9bfcf226d2749/output.txt Total script time: 30.81 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.
Related to #19811.