Change PDFDocument.prototype._xfaStreams to return a Map
#19805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a `Map` rather than an `Object` is a nicer, since it has better support for both iteration and checking if a key exists. We also change the initial values to be `null`, rather than empty strings, and reduce duplication when creating the `Map`. *Please note:* Since this is worker-thread code, these changes are "invisible" at the API-level.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0af9fb7b286f632/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d17a022b7509559/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0af9fb7b286f632/output.txt Total script time: 30.05 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d17a022b7509559/output.txt Total script time: 61.79 mins
|
timvandermeij
approved these changes
Apr 12, 2025
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a
Maprather than anObjectis a nicer, since it has better support for both iteration and checking if a key exists.We also change the initial values to be
null, rather than empty strings, and reduce duplication when creating theMap.Please note: Since this is worker-thread code, these changes are "invisible" at the API-level.