-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Avoid to create an array when setting the text matrix #19772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/38feabbef2c653a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/95e4f50ca64554b/output.txt |
It's most likely fine as-is, but have you checked that the following optimization-case supports pdf.js/src/core/operator_list.js Lines 388 to 394 in 9217d25
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/38feabbef2c653a/output.txt Total script time: 30.26 mins
Image differences available at: http://54.241.84.105:8877/38feabbef2c653a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/95e4f50ca64554b/output.txt Total script time: 62.09 mins
Image differences available at: http://54.193.163.58:8877/95e4f50ca64554b/reftest-analyzer.html#web=eq.log |
Yes, I saw that and I just read the code and it looked fine to me. Then I supposed that the we've a test for it. |
15c60bb
to
4c63905
Compare
I checked locally with the pdf in #4316 and it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1724d59fecd5e45/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b14873d3c0c4c18/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1724d59fecd5e45/output.txt Total script time: 16.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b14873d3c0c4c18/output.txt Total script time: 29.80 mins
|
No description provided.