Attempt to get bundlers to leave Emscripten Compiler generated URLs alone (issue 19761)
#19767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2300a37d9ff2c68/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ac0eba87baa2cbc/output.txt |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… alone (issue 19761) Note that we load all wasm-files manually, however the Emscripten Compiler (emcc) unfortunately generates `URL`s for fallback wasm-file loading. In the PDF.js build-scripts we work-around that by using suitable Webpack-options, however that apparently doesn't work when third-party users re-bundle our code and we thus try to work-around this by adding "ignore comments" to these `URL`s (similar to how we handle `import`-statements).
Snuffleupagus
force-pushed
the
issue-19761
branch
from
7b1f986 to
20e06c4
Compare
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ac0eba87baa2cbc/output.txt Total script time: 3.57 mins
Image differences available at: http://54.193.163.58:8877/ac0eba87baa2cbc/reftest-analyzer.html#web=eq.log |
nicolo-ribaudo
approved these changes
Apr 4, 2025
1 task
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2300a37d9ff2c68/output.txt Total script time: 30.08 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we load all wasm-files manually, however the Emscripten Compiler (emcc) unfortunately generates
URLs for fallback wasm-file loading.In the PDF.js build-scripts we work-around that by using suitable Webpack-options, however that apparently doesn't work when third-party users re-bundle our code and we thus try to work-around this by adding "ignore comments" to these
URLs (similar to how we handleimport-statements).