Skip to content

Replace UpdateRectMinMax by getAxialAlignedBoundingBox #19763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Replace UpdateRectMinMax by getAxialAlignedBoundingBox #19763

merged 1 commit into from
Apr 4, 2025

Conversation

calixteman
Copy link
Contributor

and don't use array destructuring because it induces a memory and perf penalties.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3972d4fae97aaed/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c97b27cf1c35bde/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/c97b27cf1c35bde/output.txt

Total script time: 31.03 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 50
  different ref/snapshot: 8

Image differences available at: http://54.241.84.105:8877/c97b27cf1c35bde/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following code needs to be updated as well, given the errors in the browsertest logs:

pdf.js/src/display/pattern_helper.js

Lines 683 to 688 in 16c8765

graphics.current.updateRectMinMax(getCurrentTransform(graphics.ctx), [
x0,
y0,
x1,
y1,
]);

@calixteman calixteman force-pushed the simplify_updaterect branch from 4625302 to a446724 Compare April 3, 2025 20:06
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3972d4fae97aaed/output.txt

Total script time: 62.26 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 50
  different ref/snapshot: 8

Image differences available at: http://54.193.163.58:8877/3972d4fae97aaed/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eaf132f3e73bdf7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d6ee3038adb068c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/eaf132f3e73bdf7/output.txt

Total script time: 16.25 mins

  • Regression tests: FAILED
  different ref/snapshot: 9

Image differences available at: http://54.241.84.105:8877/eaf132f3e73bdf7/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d6ee3038adb068c/output.txt

Total script time: 29.67 mins

  • Regression tests: FAILED
  different ref/snapshot: 9

Image differences available at: http://54.193.163.58:8877/d6ee3038adb068c/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the explanation for the ref-test "failures", is it simply that by using 32-bit floats we get ever so slightly different rounding behaviour now?

@calixteman
Copy link
Contributor Author

What's the explanation for the ref-test "failures", is it simply that by using 32-bit floats we get ever so slightly different rounding behaviour now?

I don't know what could be another explaination.

@calixteman
Replace UpdateRectMinMax by getAxialAlignedBoundingBox
e7a9515 
and don't use array destructuring because it induces a memory and perf penalties.
@calixteman calixteman force-pushed the simplify_updaterect branch from a446724 to e7a9515 Compare April 4, 2025 17:58
Snuffleupagus
Snuffleupagus approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit 7eef7df into mozilla:master Apr 4, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/674055e5cfffcd4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/78b95ed14dc8c6f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/674055e5cfffcd4/output.txt

Total script time: 16.25 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/78b95ed14dc8c6f/output.txt

Total script time: 29.65 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus