Remove few useless beginPaths #19732
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/5245ee83af4ab1f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/39c8643ed45a23a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5245ee83af4ab1f/output.txt Total script time: 29.38 mins
Image differences available at: http://54.241.84.105:8877/5245ee83af4ab1f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/39c8643ed45a23a/output.txt Total script time: 60.00 mins |
calixteman
force-pushed
the
rm_useless_beginpath
branch
from
349403d to
ed0a3b7
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1f4a5ccceef40ee/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9a8b7bad7a26150/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9a8b7bad7a26150/output.txt Total script time: 29.60 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1f4a5ccceef40ee/output.txt Total script time: 60.00 mins |
There was a problem hiding this comment.
Just to improve my understanding: Is the reason that beginPath is no longer necessary that we're doing basic drawing with Path2D now, which means that there's no "partial" paths that need to cleared anymore?
Also, does this improve performance in any noticeable way in some (currently slow) PDFs?
r=me, thank you.
Yep exactly.
As far as I know: no.
|
The ctx current path is no more changed since we use some Path2D when we want to fill/stroke them. It makes calling ctx.beginPath useless.
calixteman
force-pushed
the
rm_useless_beginpath
branch
from
ed0a3b7 to
a35443f
Compare
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c1cd8867703557/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/66c55864718bd94/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/66c55864718bd94/output.txt Total script time: 16.57 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3c1cd8867703557/output.txt Total script time: 30.01 mins
|
The ctx current path is no more changed since we use some Path2D when we want to fill/stroke them.
It makes calling ctx.beginPath useless.