-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Pre-apply the transform when building the Path2D
objects for Type3-fonts
#19731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-apply the transform when building the Path2D
objects for Type3-fonts
#19731
Conversation
…fonts Rather than updating the transform every time that we're painting a Type3-glyph, we can instead just compute the "final" coordinates during building of the `Path2D` objects.
… objects Originally this function would "manually" invoke the rendering commands for Type3-glyphs, however that was changed some time ago: - Initial `Path2D` support was added in PR 14858, but the old code kept for Node.js compatibility. - Since PR 15951 we've been using a `Path2D` polyfill in Node.js environments. Hence, after the previous commit, we can further simplify this function by *directly* returning/using the `Path2D` object when rendering Type3-glyphs; see also mozilla#19731 (comment) While this won't improve performance significantly, when compared to the introduction of `Path2D`, it definately cannot hurt.
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5caca448a8e46d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9df2599fe667edc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5caca448a8e46d4/output.txt Total script time: 37.89 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9df2599fe667edc/output.txt Total script time: 60.00 mins |
/botio botmakeref |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/5cb72b197d4e917/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/7db784a85357181/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5cb72b197d4e917/output.txt Total script time: 15.82 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7db784a85357181/output.txt Total script time: 34.48 mins
|
Rather than updating the transform every time that we're painting a Type3-glyph, we can instead just compute the "final" coordinates during building of the
Path2D
objects.