Use Util.rectBoundingBox more in the annotation code (PR 19713 follow-up)
#19726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-up) By changing the return format of the various `pointsCallback` functions we can use the `Util.rectBoundingBox` helper in the `MarkupAnnotation.prototype._setDefaultAppearance` method as well, thus shortening the code slightly.
Snuffleupagus
force-pushed
the
_setDefaultAppearance-bbox
branch
from
7fcae41 to
29788eb
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/096056fd86d629b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/03149d012cf1cd5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/096056fd86d629b/output.txt Total script time: 30.25 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/03149d012cf1cd5/output.txt Total script time: 60.00 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the return format of the various
pointsCallbackfunctions we can use theUtil.rectBoundingBoxhelper in theMarkupAnnotation.prototype._setDefaultAppearancemethod as well, thus shortening the code slightly.