Isolate the "create editor with keyboard" freetext editor integration tests #19711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests This commit reduces the number of freetext editor integration test suite failures, in full isolation, from 6 to 5 by fixing the following issues in the "create editor with keyboard" block: - The second test relied on the first test to enable freetext editing mode and put focus on the page (annotation layer). For isolation we now do that explicitly in the second test. - The second test relied on the first test for the editor numbering. For isolation we change the editor numbering to the one after initial document load. Moreover, the test names have been updated to clarify with scenario is being tested, which came up during comparison of the changes against commit ea5eafa to make sure that we are still testing the originally intended scenarios (confirmed by disabling the relevant code from the commit per scenario and noticing the corresponding test failing).
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/27b506dc7e847ea/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1d4dc03748646c0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/27b506dc7e847ea/output.txt Total script time: 11.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1d4dc03748646c0/output.txt Total script time: 27.99 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the number of freetext editor integration test suite failures, in full isolation, from 6 to 5 by fixing the following issues in the "create editor with keyboard" block:
Moreover, the test names have been updated to clarify with scenario is being tested, which came up during comparison of the changes against commit ea5eafa to make sure that we are still testing the originally intended scenarios (confirmed by disabling the relevant code from the commit per scenario and noticing the corresponding test failing).
Fixes a part of #19065.
Note that this should also reduce the number of test failures in case of intermittent failures. If the first test failed previously, the second test would automatically fail too, whereas now the second test can pass because it's run independently of the first test. This should avoid the double failures as seen in e.g. http://54.241.84.105:8877/be83f9ee48219b6/output.txt.