Fix the MD5 computation in the src/core/writer.js file
#19693
Conversation
Snuffleupagus
force-pushed
the
writer-fix-md5
branch
from
c3d58b8 to
d117c3d
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/be83f9ee48219b6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/40f43de3848eac2/output.txt |
|
Jasmine has some APIs that allow controlling time when testing: https://jasmine.github.io/api/5.6/Clock. I don't know if |
Currently the MD5 computation doesn't actually work (at all?), since we're invoking the `calculateMD5` function without providing all of the necessary parameters and the PDF-data thus isn't taken into account. Fixing this caused unit-tests to fail, which isn't that surprising since the current date/time is used in the MD5 computation, and we thus utilize Jasmine to work-around that.
Snuffleupagus
force-pushed
the
writer-fix-md5
branch
from
d117c3d to
e6c869c
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/be83f9ee48219b6/output.txt Total script time: 30.24 mins
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0ab00de7f063ecb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0ab00de7f063ecb/output.txt Total script time: 2.37 mins
|
Currently the MD5 computation doesn't actually work (at all?), since we're invoking the
calculateMD5function without providing all of the necessary parameters and the PDF-data thus isn't taken into account.Fixing this caused unit-tests to fail, which isn't that surprising since the current date/time is used in the MD5 computation, and we thus utilize Jasmine to work-around that.