Skip to content

Improve the implementation in src/core/writer.js a little bit #19692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Improve the implementation in src/core/writer.js a little bit #19692

merged 1 commit into from
Mar 20, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

  • Let the writeString helper function return the new offset, to avoid having to recompute that in multiple spots.

  • In the computeMD5 helper function we can create the md5Buffer via Array-destructuring, rather than using a manual loop.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/040553b9c66b8ce/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ad9c7c00294f094/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/040553b9c66b8ce/output.txt

Total script time: 30.02 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ad9c7c00294f094/output.txt

Total script time: 59.78 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Improve the implementation in src/core/writer.js a little bit
50eb97a 
 - Let the `writeString` helper function return the new offset, to avoid having to recompute that in multiple spots.

 - In the `computeMD5` helper function we can create the `md5Buffer` via Array-destructuring, rather than using a manual loop.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5c3d0e326d7f23d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/b2c9f4d7c0e4b20/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5c3d0e326d7f23d/output.txt

Total script time: 2.39 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b2c9f4d7c0e4b20/output.txt

Total script time: 7.87 mins

  • Unit Tests: Passed

calixteman
calixteman approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 8f4c016 into mozilla:master Mar 20, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the writer-improve branch March 20, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman