[api-minor] Attempt to support fetching the raw data of the PDF document from the PDFDocumentLoadingTask-instance (issue 15085)
#19632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
issue-15085
branch
from
b2d6312 to
58e6be3
Compare
Snuffleupagus
force-pushed
the
issue-15085
branch
from
58e6be3 to
42b6964
Compare
Snuffleupagus
force-pushed
the
issue-15085
branch
from
42b6964 to
4073004
Compare
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3e05f4394abea18/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2582765eefbdb56/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2582765eefbdb56/output.txt Total script time: 2.48 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3e05f4394abea18/output.txt Total script time: 7.96 mins
|
…ent from the `PDFDocumentLoadingTask`-instance (issue 15085) The new API-functionality will allow a PDF document to be downloaded in the viewer e.g. while the PasswordPrompt is open, or in cases when document initialization failed. Normally the raw data of the PDF document would be accessed via the `PDFDocumentProxy.prototype.getData` method, however in these cases the `PDFDocumentProxy`-instance isn't available.
Snuffleupagus
force-pushed
the
issue-15085
branch
from
4073004 to
9e8d4e4
Compare
Snuffleupagus
changed the title
PDFDocumentLoadingTask-instance (issue 15085)PDFDocumentLoadingTask-instance (issue 15085)
Snuffleupagus
requested review from
timvandermeij and
calixteman
and removed request for
timvandermeij and
calixteman
timvandermeij
approved these changes
Mar 16, 2025
|
Looks good; thanks! |
|
Cheers, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API-functionality will allow a PDF document to be downloaded in the viewer e.g. while the PasswordPrompt is open, or in cases when document initialization failed.
Normally the raw data of the PDF document would be accessed via the
PDFDocumentProxy.prototype.getDatamethod, however in these cases thePDFDocumentProxy-instance isn't available.Smaller diff with https://github.com/mozilla/pdf.js/pull/19632/files?w=1
Edit: I also tested this patch in a local Firefox (artifact) build, and it seems to work as intended since the PDF document can now be correctly downloaded in the situations outlined above.