Use fewer hasFieldFlag calls in the src/core/annotation.js file
#19393
Conversation
We lookup a number of field-flags multiple times, which seems unnecessary.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/66a00cdc81a833e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f98de91942e7d97/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f98de91942e7d97/output.txt Total script time: 2.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/66a00cdc81a833e/output.txt Total script time: 7.50 mins
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/604f8714c95601d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5e3b1fb1c87989d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5e3b1fb1c87989d/output.txt Total script time: 16.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/604f8714c95601d/output.txt Total script time: 30.08 mins
|
|
Out of curiosity, did you check that every flag we read is used when rendering the annotation (of course if there's an html/css counterpart like the password one we missed) ? |
I've just checked, and it appears that everything is actually being used now. |
We lookup a number of field-flags multiple times, which seems unnecessary.