Replace the EXIF-block with dummy data to prevent JPEG images being rotated (bug 1942064) #19356
Conversation
Snuffleupagus
force-pushed
the
bug-1942064-2
branch
from
c3390d9 to
d889568
Compare
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2e3d7088a7a02a0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e6883e004339adf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2e3d7088a7a02a0/output.txt Total script time: 16.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e6883e004339adf/output.txt Total script time: 30.95 mins
|
…otated (bug 1942064) The `ImageDecoder` will respect the EXIF orientation, which can lead to JPEG images being incorrectly rotated. To avoid this we replace the entire EXIF-block with dummy data, which works since it'll cause EXIF parsing to bail out early in Firefox; see https://searchfox.org/mozilla-central/rev/9a66d18cb35595c89f499a1011c9dd7e573fce77/image/decoders/EXIF.cpp#130-138
Snuffleupagus
force-pushed
the
bug-1942064-2
branch
from
d889568 to
c4ba3ac
Compare
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a659bd5c3adeab0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/dd5002ff1d17843/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/dd5002ff1d17843/output.txt Total script time: 16.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a659bd5c3adeab0/output.txt Total script time: 29.97 mins
|
The
ImageDecoderwill respect the EXIF orientation, which can lead to JPEG images being incorrectly rotated. To avoid this we replace the entire EXIF-block with dummy data, which works since it'll cause EXIF parsing to bail out early in Firefox; see https://searchfox.org/mozilla-central/rev/9a66d18cb35595c89f499a1011c9dd7e573fce77/image/decoders/EXIF.cpp#130-138