Inline the default Factory-definitions in getDocument
#19341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4def0cfce396a54/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4def0cfce396a54/output.txt Total script time: 28.18 mins
|
timvandermeij
approved these changes
Jan 18, 2025
- Most of the these are only used in the `src/display/api.js` file, and this leads to slightly shorter code. - A number of unit-tests need a `BaseCanvasFactory`-instance, however that one is available through the `PDFDocumentProxy`-instance nowadays. - For other unit-tests the remaining necessary default Factory-definitions can be moved into the `test/unit/test_utils.js` file.
Snuffleupagus
force-pushed
the
api-Default-Factory
branch
from
4ac15a5 to
db43f15
Compare
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a98d29528c03b72/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a98d29528c03b72/output.txt Total script time: 2.33 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the these are only used in the
src/display/api.jsfile, and this leads to slightly shorter code.A number of unit-tests need a
BaseCanvasFactory-instance, however that one is available through thePDFDocumentProxy-instance nowadays.For other unit-tests the remaining necessary default Factory-definitions can be moved into the
test/unit/test_utils.jsfile.