Allow searching for number-number on two lines #19324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Jan 14, 2025
When a dash separates two digits, it's very likely to not be a hyphen inserted to split a word into two lines (e.g. "par\n-ser"), but rather either a minus sign, a range, or a date. For example, in the tracemonkey PDF there is `2008-02` (a date) split across two lines. Preserving the dash, similarly to how we do for compound words, allows searches for "2008-02" to find a match.
nicolo-ribaudo
force-pushed
the
search-dash-date
branch
from
1286f30 to
8358ab6
Compare
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4491bd3f7e08e1d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b332744a1d3841d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b332744a1d3841d/output.txt Total script time: 2.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4491bd3f7e08e1d/output.txt Total script time: 6.95 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally going for a more complex regexp that checks for "letter"+"diacritics"+"dash"+"newline"+"letter", but if there are diacritics it's already very likely that they are preceded by a letter so the existing
(\\p{M}+(?:-\\n)?)is good enough.